I turned into a shake snob a few years ago. Agreed on the comments for Whitey's and Steak n Shake. I would also add the UDF (United Dairy Farmers) convenience stores in the Cincy area. Really good stuff.
At Steak n Shake, the shakes are half price from 2-4...happy hour!
Smashburger doesn't make a bad shake either. I disagree on the support for Culvers--both times I've had their shakes I've been disappointed. Carl's Jr. is just OK in my book.