I was told 15+ years ago not to put the "make up the room" sign out (or switch it on) as it generally indicates you are not in the room to anyone going by. They will check anyway (and as earlier posted), sometimes when you are genuinely not wanting to be disturbed! I still don't put the sign out.

These days the level of security at many hotels is better, but not everywhere.