I've only been to Agadir in Morocco and was only there about 3-days but I genuinely felt very safe.

A couple of chancers walking up trying to sell you stuff/begging but I either ignored them or said no and that was really the end of it.

I hear things can be different if you're female? I can't attest to that either way but it wouldn't surprise me if their experiences differ greatly to mine but I had a really nice time in Agadir and would recommend it (but with the caveat that my 3-days was enough for me - it's not a 2-week holiday type of place IMO).

The only scam you really need to watch for is that Agadir Airport, doesn't accept Ryanair's mobile boarding passes (I don't think they have the technology) so bung your hotel receptionist a couple of quid to print it off for you because they will still demand £55/Euros at the Airport to print your pass for you (even though you've checked in online and have the boarding pass on your mobile).