Depends entirely on your requirements. If you need 100GB over 28 days, then yes, your option is probably best. Personally, I don't need that.

Airalo has a 3GB French SIM, valid for 30 days, for US$10 ($13 if you want coverage through most of Europe rather than just France). That's probably all I need for a week or so in France, with the convenience that I can likely be using it as the plane is still taxiing to the gate, plus I can still have my US SIM in my phone doing "Wifi" calling over the eSIM. esimdb has even cheaper options listed.

Then there's the countries where local SIMs are difficult to get, or not possible at all. As I said above, I used an eSIM in Turkey recently. I actually could have picked up a local SIM cheaper than my eSIM (although likely not at the airport), and it would have worked. But if I then went back to Turkey again, my phone wouldn't work at all - it would have been blacklisted by the Telcos as I hadn't registered it with the government (which costs several hundred US$ to do) within 120 days of using it with a local sim.

I used to do the local SIM thing, and still do in Australia (although mainly for the convenience of having a fixed number - it costs me more than an eSIM would), but otherwise find an eSIM by far the best option for my use case. Different use cases will have different solutions.