Welcome to FT.
The biggest learning to take out of this situation is to not bother with asking BA reps about BA matters, since some of them are clueless.
You will have no problem at all with the spray in hold luggage, and providing it is less than 100ml, it will be accepted into the cabin without issue.