I do have status on Lufthansa, and personally if it was the same fare and all other factors were the same, I would not choose Lufthansa. They are a good, very professional (when not on strike), safe, reliable airline with a fantastic European network, but as with BA they come with all sorts of downsides. The Silver level on Lufthansa is pretty weak, the lounge offering in heaps of European airports is dire (Aspire is a typical partner), non existant in places like NCL thanks to the Eurowings subsidiary, and Miles and More is not a patch on BAEC. There is just one Senator lounge (in FRA only) which may come close to London's three Flounges though the range of available food is under half that of BA and the alcohol provision much weaker. T2 Senator is sparkling new but has even less food and drink options than FRA. Now I normally enjoy the MUC transfer experience - though if you think BA's Ready to Fly is harsh, just wait until you see the LH agents in MUC slamming the gate doors shut the moment they see connecting passenger madly running towards them. And so I could go on. Still, aware pf the limitations, I am generally a happy customer on Lufthansa, and the EDI-FRA service is generally a fairly slick route into that vast network.

I think it is all to easy to have a reasonably good experience on something new and think it's always briliiant. Familiarity and contempt I suppose.