If its a special trip that's what I do. If I'm repeating a travel destination, I don't usually prepare a scrapbook the second time because it takes a long time. A scrapbook helps you to remember good trips, places and things that after some years you tend to forget. It is useful if you return to a place. I'm going on a cruise in a week and a half with 2 friends. It is the first cruise for one of them and she wants to buy many shore excursions. I checked my scrapbook of a similar cruise and I told her which ones I would'nt be choosing because I already took them.
In terms of documenting the trip, I save almost everything: ie: museums, shows stubs, just the plastic card keys with the specific hotel name (location) not the hotel chain generic ones, etc.