Shock absorbers (gas type especially) are classed as Dangerous Goods and covered by the IATA Dangerous Goods regs. You are lucky your relative only had them confiscated. I doubt BA will reimburse the bag but worth a shot.
I am amazed they told you they were acceptable. Please do complain and include the email as it shows a weakness in the Dangerous Goods awareness of customer services.