No reason not to request the upgrade at the time you make the reservation or any other time before ticketing. The upgrade process works off the PNR which is created immediately.

However, the days of being upgraded while a reservation is on hold are gone, now that the hold option is no longer available within 7 days of departure.