If I'm going to do that, then I will purchase my TSA-approved locks (that a motivated TSO could use a special TSA key to unlock - but probably won't). I will buy those locks that have a 'guaranteed replacement' warranty.

I quit doing that because although I never had a problem getting a new lock, it wasn't worth my time. Now I use zip ties. Cheaper and easier to replace and not as tempting.

To some TSOs, the lock sends a message: 'I have something worth stealing, even if you didn't see anything on the x-ray'. I have actually had a lock clipped on a snowboard bag - except the lock was on the zipper pull and the bag was not actually locked. TSA didn't even bother to look - just cut the lock and left it in the bag with a 'love note'.

There's probably a market for these locks with first or very infrequent fliers, or fliers who live/travel abroad. I don't think most domestic US fliers are going to find them more useful than the regular locks that TSOs regularly clip out of laziness.