It is an approach that I learned from others in this forum.
I probably sent the email about a week prior to arrival and it's just a very simple and polite request for consideration for an upgrade. If there's a special occasion (birthday, anniversary, etc.) I might point it out.