On TWA this was an official company-wide policy which was instituted after the crash of TW 843 at JFK in 1992.

A passenger noticed one of the engines on fire, which led to a harrowing sequence of events, an aborted take-off (after lift off had begun) and--obviously--a hard landing.

With quick thinking and great teamwork, all 292 aboard were led safely off the plane within about 90 seconds with any serious injuries. A few moments later, the plane was a smoldering heap.

After that, TWA decided that, had window shades been closed, the burning engine might not have been seen, potentially leading to a major tragedy.

I think having all window shades up during take off is an excellent idea.