It went fine for me. iTunes upgraded first when I plugged into sync. After that I upgraded to iOS4. Immediately after upgrading there were a few oddities but a reboot of the phone cleared all of those.

I'm not an Apple fan so if I really had something negative to say about iOS4 I would :-)