The Americans I know in that situation show the US passport in the US, the Chinese passport in China. The other passport is shown to show that you have the right to enter the destination country as you don't have a visa for it.

A couple of years ago my wife had to show her old passport when getting a new Chinese visa as they wanted to make sure she didn't have a Chinese passport. (She's China-born.)