i consistently find that morning checkin creates the best odds - I typically go first to the hotel, check-in, explain that I don't need the room until later in the afternoon, and would appreciate any upgrades that are available. Then I go on to my meeting.
Of course, if you're flying in at 6pm, that won't work, and I find in these situations my upgrade percentage declines significantly as a result.