Another visa question
 

I'm a British citizen that lives in New York (British passport and US greencard).

I'm planning the following trip in March:
NYC to Hong Kong (5 days)
Hong Kong to Shanghai (5 days)
Shanghai to NYC (via Hong Kong)

I gather from searching the forums that I don't need a visa to enter Hong Kong, but I can't seem to clarify if I need a visa to travel from Hong Kong to Shanghai?

If I do need a visa can I obtain this in NY for my UK passport?
Is it possible to wait til I am in Hong Kong and potentially obtain one there?

Many thanks in advance for any advice! :)

This question is answered already in detail in the various visa threads (one, two).

But to summarise: you need a visa for Shanghai. TWOV does not apply as you will 1) be in SH for >72 hours, and 2) you are both arriving from and departing to HK, so it wouldn't qualify even if <72 hours.

You are almost always better off obtaining a Chinese visa in your home country whenever possible as you will tend to get a better visa (more entries, longer duration). There are also anecdotal reports that it has become significantly more difficult or even impossible to obtain visas in HK since 1 January, at least for some nationalities. If you really want to attempt this, get in touch with Forever Bright (+852 2369 3188 or [email protected]) or another reputable visa agent to confirm the current situation for UK citizens.

Yes, you can obtain a Chinese visa in NY. As you are holding British passport, it shouldn't be big difference where you obtain Chinese visa.

Multiple visa is hard to obtain at the moment, especially for longer terms (2 year) visa.

1) You need a visa for China, no visa for HK. You only need a single-entry visa for this itinerary. If you need a multiple entry for future visits, you're best bet is HK not anywhere in the USA. Even UK is difficult to get multi-entry for UK passport holders.
2) With a greencard, you can get a single-entry visa in the USA on your British passport. Will probably need to show your flight reservations and hotel reservations in Shanghai as part of the application.
3) Getting a Chinese visa in HK is absolutely doable, but in order not to waste time, use suggestion above and go through Forever Bright agency (reasonable fee) to do the legwork and free up your time, instead of queueing at the Commissioners Office in Wanchai. FB can do next-day service. Processing generally not done on weekends or Chinese holidays.

If you're going for a tourist L visa, no invitation letter is needed. If going for a business F visa, invitation letter needed in NY, often not needed for a Brit applying in HK if you use an agent, but best to check FB to see what the latest is.